Discussion:
Robin Dunn: A mistake in regex??
Boštjan Mejak
2013-03-16 21:37:10 UTC
Permalink
Robin, you made a regex in Phoenix source code in buildtools/config.py on
line 866 which is:
result = re.search('^\s+SONAME\s+(.+)$', output, re.MULTILINE)

Don't you mean this:
result = re.search('^\s+SOName\s+(.+)$', output, re.MULTILINE)

Notice SONAME vs. SOName thing changed in the regex.
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Robin Dunn
2013-03-16 22:44:36 UTC
Permalink
Post by Boštjan Mejak
Robin, you made a regex in Phoenix source code in buildtools/config.py
result = re.search('^\s+SONAME\s+(.+)$', output, re.MULTILINE)
result = re.search('^\s+SOName\s+(.+)$', output, re.MULTILINE)
Notice SONAME vs. SOName thing changed in the regex.
No. The text that is being scanned (the output of objdump) uses
"SONAME", and "SOName" is just how I used it in function and variable
names. Does your objdump not use all caps for that record?
--
Robin Dunn
Software Craftsman
http://wxPython.org
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Boštjan Mejak
2013-03-16 23:35:28 UTC
Permalink
Uhm, yes, objdump uses all caps for that record by me as well.
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Loading...