Discussion:
TimeCtrl in wx3
Paul Wiseman
2014-09-22 15:39:36 UTC
Permalink
I noticed a bit of odd behaviour when upgrading to wxPython 3.0.1.1
with the wx.lib.masked.TimeCtrl.

Namely 3 things,
- Using colon / tab to change the selection did weird things - to
recreate type '11:' in the timectrl __name__ __main__ demo then begin
typing again.
- Clicking or moving the cursor to a different field, then
incrementing with the spin control or arrow keys incremented where the
cursor used to be
- 24hr format was always being used for me, despite passing False to
the constructor.

I took a look at the issues and created patches for the 3 bugs which
I've attached.

Whats the normal process of getting these reviewed / applied? Should I
make a ticket on wxwidgets tracker?

Thanks!

Paul
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Werner
2014-09-22 15:52:18 UTC
Permalink
Hi Paul,
Post by Paul Wiseman
I noticed a bit of odd behaviour when upgrading to wxPython 3.0.1.1
with the wx.lib.masked.TimeCtrl.
Namely 3 things,
- Using colon / tab to change the selection did weird things - to
recreate type '11:' in the timectrl __name__ __main__ demo then begin
typing again.
- Clicking or moving the cursor to a different field, then
incrementing with the spin control or arrow keys incremented where the
cursor used to be
- 24hr format was always being used for me, despite passing False to
the constructor.
I took a look at the issues and created patches for the 3 bugs which
I've attached.
Whats the normal process of getting these reviewed / applied? Should I
make a ticket on wxwidgets tracker?
For wxPython classic I would create a ticket on
http://trac.wxwidgets.org/ post the above with the ticket number to the
wxPython-dev list.

For wxPython phoenix I would just create PR's (Pull Request) on
https://github.com/RobinD42/Phoenix/pulls and give the above details on
the PR.

Werner
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Paul Wiseman
2014-09-22 15:55:08 UTC
Permalink
Thanks Werner,

I guess I'm using classic? (wx.version() says classic)
Post by Werner
Hi Paul,
Post by Paul Wiseman
I noticed a bit of odd behaviour when upgrading to wxPython 3.0.1.1
with the wx.lib.masked.TimeCtrl.
Namely 3 things,
- Using colon / tab to change the selection did weird things - to
recreate type '11:' in the timectrl __name__ __main__ demo then begin
typing again.
- Clicking or moving the cursor to a different field, then
incrementing with the spin control or arrow keys incremented where the
cursor used to be
- 24hr format was always being used for me, despite passing False to
the constructor.
I took a look at the issues and created patches for the 3 bugs which
I've attached.
Whats the normal process of getting these reviewed / applied? Should I
make a ticket on wxwidgets tracker?
For wxPython classic I would create a ticket on http://trac.wxwidgets.org/
post the above with the ticket number to the wxPython-dev list.
For wxPython phoenix I would just create PR's (Pull Request) on
https://github.com/RobinD42/Phoenix/pulls and give the above details on the
PR.
Werner
--
You received this message because you are subscribed to the Google Groups
"wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Werner
2014-09-22 16:10:08 UTC
Permalink
Hi Paul,
Post by Paul Wiseman
Thanks Werner,
I guess I'm using classic? (wx.version() says classic)
Wasn't aware that 'classic' is shown, if you had phoenix it would be
something like this:

import wxversion
wxversion.select('3.0-phoenix', True)
import wx
wx.version()
'3.0.2.dev77483 msw (phoenix)'

Phoenix is not officially released, and there are only snapshots
available for it.

If you want to to try it and test and provided patches:) you have the
documentation here:

http://wxpython.org/Phoenix/docs/html/main.html

and you can install it with pip:

pip install -U --pre -f http://wxpython.org/Phoenix/snapshot-builds/
wxPython_Phoenix

Werner
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Paul Wiseman
2014-09-22 16:21:32 UTC
Permalink
Post by Werner
Hi Paul,
Post by Paul Wiseman
Thanks Werner,
I guess I'm using classic? (wx.version() says classic)
Wasn't aware that 'classic' is shown, if you had phoenix it would be
import wxversion
wxversion.select('3.0-phoenix', True)
import wx
wx.version()
'3.0.2.dev77483 msw (phoenix)'
Phoenix is not officially released, and there are only snapshots available
for it.
Ah thanks I didn't realise that somehow, I just thought 3.x was phoenix.
Post by Werner
If you want to to try it and test and provided patches:) you have the
http://wxpython.org/Phoenix/docs/html/main.html
pip install -U --pre -f http://wxpython.org/Phoenix/snapshot-builds/
wxPython_Phoenix
I'll look at patching phoenix and creating some pull requests.

I posted the wxwidgets tracker link to wxPython-dev list but it
doesn't appear to have shown up? I've never posted there before so
maybe I don't have permissions?
Post by Werner
Werner
--
You received this message because you are subscribed to the Google Groups
"wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Werner
2014-09-22 17:43:26 UTC
Permalink
Hi Paul,

On 9/22/2014 18:21, Paul Wiseman wrote:
...
Post by Paul Wiseman
I posted the wxwidgets tracker link to wxPython-dev list but it
doesn't appear to have shown up? I've never posted there before so
maybe I don't have permissions?
I do see it. How did you post it, if from a mail client with you gmail
account I think you will not get it to your mail client.

Werner
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Nathan McCorkle
2014-09-22 18:29:46 UTC
Permalink
Post by Werner
Hi Paul,
...
Post by Paul Wiseman
I posted the wxwidgets tracker link to wxPython-dev list but it
doesn't appear to have shown up? I've never posted there before so
maybe I don't have permissions?
I do see it. How did you post it, if from a mail client with you gmail
account I think you will not get it to your mail client.
I see it, probably first-time posts are queued for manual approval to
reduce/prevent spam.
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Robin Dunn
2014-09-24 01:11:43 UTC
Permalink
Post by Nathan McCorkle
I see it, probably first-time posts are queued for manual approval to
reduce/prevent spam.
That's correct.
--
Robin Dunn
Software Craftsman
http://wxPython.org
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Florian Höch
2014-09-24 20:01:21 UTC
Permalink
Post by Werner
pip install -U --pre -f http://wxpython.org/Phoenix/snapshot-builds/
Thanks for this. I wasn't even aware that it is so easy to test out
Phoenix without building it myself :)

I've updated an application I develop for Phoenix compatibility now and
was very pleased that it didn't require many changes (although I'm using
a compatibility layer that re-implements some removed/renamed functions
because I need compatibility with wxPython 2.8.x and 3.x classic).

The only problem I ran into with Phoenix has to do with
wx.lib.delayedresult, i.e. sometimes I am getting a traceback like the
following (this is under Windows 7 x64, Python 2.7.6 win32, Phoenix
3.0.2.dev77756):

Exception in thread Thread-4:
Traceback (most recent call last):
File "C:\Python27\Lib\threading.py", line 810, in __bootstrap_inner
self.run()
File "C:\Python27\Lib\threading.py", line 763, in run
self.__target(*self.__args, **self.__kwargs)
File "C:\Python27\lib\site-packages\wx\lib\delayedresult.py", line
276, in wrapper
sender.sendResult(result)
File "C:\Python27\lib\site-packages\wx\lib\delayedresult.py", line
112, in sendResult
delayedResult = DelayedResult(result, jobID=self.__jobID)
AttributeError: SenderCallAfter instance has no attribute '_Sender__jobID'

I'd love to post a minimal example that demonstrates the issue, but so
far I'm having a hard time tracking it down (it seems to not be
reproducible at will).

Anyone else had a similar problem?
--
Florian Höch
--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...